/interface-etcd-proxy

Update the provides codesample #4

Merged
merged 1 commit into from Jul 8, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@chuckbutler @neiljerram @mbruzek
@chuckbutler
Collaborator

chuckbutler commented Jun 30, 2016 •
Edited 1 time

The provider code was assuming the databag would provide the string. It's far safer to use the etcdctl cluster info, and build this at time of request so we can filter units that are joining that may potentially block peering. RAFT will take over once connected.
@chuckbutler
Update the provides codesample 
The provider code was assuming the databag would provide the string. It's far safer to use the etcdctl cluster info, and build this at time of request so we can filter units that are joining that may portentially block peering. RAFT will take over once connected.
dda70bc
@neiljerram
Contributor

neiljerram commented Jun 30, 2016

Thanks - LGTM.
@mbruzek
Contributor

mbruzek commented Jul 8, 2016

+1 LGTM

@mbruzek mbruzek merged commit 71b1612 into juju-solutions:master Jul 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment