Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Added state indicating when the spark master changed #9
Conversation
|
+1 |
|
PR cleaned up to remove extraneous changes. |
| + return conv.get_remote('master') | ||
| + | ||
| + def is_scaled(self): | ||
| + return len(self.conversation().units) > 1 |
petevg
Oct 3, 2016
Contributor
Shouldn't there be a set_remote('this node is the master') somewhere in here? I thought that was one of the things that you wanted to keep from the old PR ...
johnsca
Oct 3, 2016
Owner
That, and actually is_scaled, were artifacts of the "subordinate to spark" approach and aren't used now. The "this node is master" doesn't even make sense in the non-subordinate case because the relation may represent multiple remote units.
On the flip side, the is_scaled check here wouldn't make sense or work in the subordinate case, because I think it would only see the single unit it's attached to. I should probably remove this as well.
| + return conv.get_remote('master') | ||
| + | ||
| + def is_scaled(self): | ||
| + return len(self.conversation().units) > 1 |
petevg
Oct 3, 2016
Contributor
Shouldn't there be a set_remote('this node is the master') somewhere in here? I thought that was one of the things that you wanted to keep from the old PR ...
johnsca
Oct 3, 2016
Owner
That, and actually is_scaled, were artifacts of the "subordinate to spark" approach and aren't used now. The "this node is master" doesn't even make sense in the non-subordinate case because the relation may represent multiple remote units.
On the flip side, the is_scaled check here wouldn't make sense or work in the subordinate case, because I think it would only see the single unit it's attached to. I should probably remove this as well.
|
LGTM/+1 |
johnsca commentedSep 20, 2016
To address juju-solutions/charm-insightedge-core#3