Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Refactor patch application #12
Conversation
|
This LGTM in general, but want to run it through the paces to make sure patch order isn't important. I'm fairly sure the patches don't overlap, but let's be thorough. |
|
The patch order actually shouldn't change with this, as the Jira tickets were created in the same order as the patches and it's sorting by the Jira ticket number in the patch file name. |
|
The Edit: Updated |
johnsca
added some commits
May 26, 2016
|
Also, I don't think these changes warrant updating the charms or bundles; they can wait until the current PR is accepted or another necessary change comes in. |
kwmonroe
reviewed
Jun 1, 2016
| - # apply configurable spark logs patch | ||
| - utils.run_as('root', 'patch', '-p1', '-s', '-i', spark_logs_patch) | ||
| + charm_dir = Path(hookenv.charm_dir()) | ||
| + for patch in sorted(glob('resources/*')): |
kwmonroe
Jun 1, 2016
Member
Let's glob resources/*.patch instead of just *. I would feel better in case we put resources in there that aren't patches.
kwmonroe
and others
added some commits
Jun 1, 2016
johnsca commentedMay 26, 2016
Rename all patches to match Jira ticket, and use ticket ordering to apply patches in order to reduce redundant code.