Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Added action to ingest file #13
Conversation
|
I couldn't get brace expansion to work inside the action without some form of juju action do namenode/0 ingest url="$(echo http://example.com/file{1..5}.tar.gz)" |
c0s
commented
Mar 30, 2016
|
I think a list (or an array) of URLs would suffice. Afterall, the githubarchive API's might be quite unique anyway. I don't know how difficult it might be, but perhaps an alternative form would be to provide a URL to a file, containing the list in it? This way a user can do:
which might reduce the amount of input significantly |
|
Yeah, i like the idea of taking a list too. Shouldn't be too hard to support in :
edit: this won't work.. this would look for a file of URLs on the machine where you run "juju action do". That file ain't gonna get over to the unit that actually does the action. |
|
Per discussion on IRC, I'm now concerned that these downloads can potentially take a fair amount of time, especially if multiple URLs are provided. That would make the action take a long time and block the hook execution queue. We should investigate a way to kick these off in the background and check the status with a separate action. |
c0s
commented
Mar 30, 2016
|
Running asynchronous actions would solve (or at least partially solve this problem). The ingest can be started right after the storage layer is ready, and continue through the rest of the stack deployment, without interfering with it. |
c0s
commented
Apr 12, 2016
|
It's all good, I believe. Should be merged, IMHO |
|
LGTM |
johnsca commentedMar 30, 2016
No description provided.