/layer-apache-php

Fix installation failure on xenial #4

Merged
merged 2 commits into from Feb 15, 2017

Conversation

Reviewers

@ktsakalozos ktsakalozos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@nobuto-m @ktsakalozos
@nobuto-m
Contributor

nobuto-m commented Jun 13, 2016 •
Edited 1 time

PHP 5.x is no longer available for xenial or newer.

Fixes #3
@nobuto-m
Fix installation failure on xenial 
PHP 5.x is no longer available for xenial or newer.

Fixes #3
245231c
reactive/apache.py
@@ -45,7 +46,10 @@ def config_changed():
def install_packages(workload):
config = hookenv.config()
hookenv.status_set('maintenance', 'Installing packages')
- packages = ['apache2', 'php5-cgi', 'libapache2-mod-php5']
+ if lsb_release()['DISTRIB_CODENAME'].lower() >= 'xenial':
@ktsakalozos

ktsakalozos Feb 13, 2017

Member

The '>=' operator on the string looks funny. Will this code keep working when the distribution names cycle?

@nobuto-m

nobuto-m Feb 13, 2017

Contributor

Right. I have pushed another revision with "16.04" instead of "xenial".

@ktsakalozos ktsakalozos merged commit 54c633c into juju-solutions:master Feb 15, 2017

@ktsakalozos
Member

ktsakalozos commented Feb 15, 2017

The patch looks good but the layer might need some updates.

@nobuto-m nobuto-m deleted the nobuto-m:xenial branch Feb 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment