Split config.changed into changed and new #61
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it can be argued that config values are "changing" from not having
a previous value in the very first hook that's fired, not distinguishing
that from a "real" change (that is, the config had a definite value
previously and has a new definite value now) makes certain constructs
difficult. On the other hand, it is relatively easy to go the other
way using
@when_any.For example:
Without the distinction,
installwill end up being called twice.