Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
bump pip version range #70
Conversation
|
I don't think this belongs here, since Xenial is pip 8.1.1 I believe this was done for reasons that pip 8.0 does not work on trusty |
wwwtyro
closed this
May 25, 2016
wwwtyro
reopened this
May 25, 2016
|
So, this is on a Xenial machine. I booted up a trusty machine and did a |
marcoceppi
referenced this pull request
May 25, 2016
Closed
pip installation conflict on Xenial charms built from layer-basic #71
|
The only reason pip was added to the wheelhouse at all instead of just using the system version was that the trusty version didn't have full wheelhouse support. We could perhaps instead add some conditional logic on the series to only update pip on trusty where it's actually required? But that would probably require still bundling the pip dependency in the wheelhouse and then just somehow excluding it for non-trusty deployments. |
|
OTOH, Having the latest version of pip on trusty wouldn't be a /bad/ thing, right? |
|
I don't think its a problem myself. I'd rather run tip of the runtime dependencies in charms myself (see: latest pip), however i'm sure there's another school of thought that disagrees with this logic (citation needed). |
|
I'm fine with this PR; I was just offering an alternative in case there was an issue with the newer pip on trusty. |
wwwtyro commentedMay 25, 2016
It looks like something was pulling in pip 8.1.1 before we get to handling the wheelhouse, causing the attempted install of pip 7.1.2 to fail: