Preserve arguments when activating venv #90

Merged
merged 1 commit into from Mar 22, 2017

Conversation

Projects
None yet
2 participants
Contributor

simonklb commented Feb 21, 2017

No description provided.

Owner

johnsca commented Feb 22, 2017

I'm fine with this, but why would a hook have any args?

Contributor

simonklb commented Feb 22, 2017

This might be a very special case, but I have an action written in bash in my charm which in turn runs a python script that I want to be left running in the background (this is the script which takes an argument and also uses the activate_venv function).

Although when I come to think about it, I could probably get the options via hookenv.action_get instead of passing them as arguments to the python script. But hey, if this isn't adding any extra baggage, it might be useful for someone else.

@johnsca johnsca merged commit 98f9647 into juju-solutions:master Mar 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment