Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Generation of CA Certificates #1
Conversation
kwmonroe
reviewed
Jul 27, 2016
| + try: | ||
| + log('Executing: {}'.format(cmd), 'debug') | ||
| + out = check_output(split(cmd)) | ||
| + return out.decode('ascii') |
kwmonroe
Jul 27, 2016
Member
you sure you want ascii here? not 'utf-8'? remember, SaMnCo may use this, and his commands all return funny French letters.
chuckbutler
Jul 27, 2016
Collaborator
The certificates and responses themselves conform to ASCII as best I can tell.
It's trivial to change however, and I'm not opposed to changing it out of the gate.
kwmonroe
Jul 27, 2016
Member
Ah, yes. I originally treated this like a generic runner, but this will only be called with cfssl bins. ascii as you wish.
|
LGTM |
kwmonroe
merged commit f35ee1b
into
juju-solutions:master
Jul 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
chuckbutler commentedJul 27, 2016
This bit of logic implements the methods and logic required to 'bootstrap' the Certificate Authority by generating the CA keys.