/layer-docker

Fixing dead link and adding more description about the build #32

Merged
merged 2 commits into from Mar 31, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mbruzek @deanmaniatis @chuckbutler
@mbruzek
Contributor

mbruzek commented Mar 31, 2016

Replacing dead link and adding more information on the build process of the layers.
@deanmaniatis

deanmaniatis commented Mar 31, 2016

That looks great, thanks for the the improvement.
README.md
+Now you should be able to deploy the assembled charm.
+
+```
+juju deploy local:<series>/<charm-name>
@chuckbutler

chuckbutler Mar 31, 2016

Collaborator

local: charms are going away. this needs to read:

juju deploy ./trusty/docker

README.md
-In a charm that wants to use docker, the integration can be as simple as placing
-the following in your charm's `compose.yaml`:
+In a layer that wants to use docker, the integration can be as simple as
+placing the following in the `compose.yaml` file:
@chuckbutler

chuckbutler Mar 31, 2016

Collaborator

s/compose.yaml/layer.yaml

@mbruzek

mbruzek Mar 31, 2016

Contributor

Doh! I can't believe I missed this!

@deanmaniatis

deanmaniatis Mar 31, 2016

This is correct, compose.yaml will not work.

@chuckbutler
Collaborator

chuckbutler commented Mar 31, 2016

@mbruzek couple of comments left inline
@chuckbutler
Collaborator

chuckbutler commented Mar 31, 2016

+1 LGTM Thanks for the quick turn around on this one @mbruzek

@chuckbutler chuckbutler merged commit d78bb50 into juju-solutions:master Mar 31, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment