/layer-docker

Adds release checking to reload_deamon call #73

Merged
merged 1 commit into from Aug 29, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@chuckbutler @mbruzek
@chuckbutler
Collaborator

chuckbutler commented Aug 29, 2016

No description provided.

@chuckbutler
Collaborator

chuckbutler commented Aug 29, 2016

related to #69
@chuckbutler
Collaborator

chuckbutler commented Aug 29, 2016

Xenial:
PASS: 3 Total: 3 (431.003215 sec)
Trusty:
PASS: 3 Total: 3 (501.546384 sec)
reactive/docker.py
+ command = ['systemctl', 'daemon-reload']
+ check_call(command)
+ else:
+ service_reload('docker')
@mbruzek

mbruzek Aug 29, 2016

Contributor

I have a strong feeling that running service docker reload would work on systemd computers as well, removing the need for this if statement. But as I don't have time to test this theory I will allow it. We should determine if reload works on xenial and come back to this in the future.

@mbruzek
Contributor

mbruzek commented Aug 29, 2016

Fixes #74
@mbruzek
Contributor

mbruzek commented Aug 29, 2016

+1

@mbruzek mbruzek merged commit 2e1b5a8 into juju-solutions:master Aug 29, 2016

@chuckbutler chuckbutler deleted the chuckbutler:fix-upstart-daemon-reload branch Sep 4, 2016

@chuckbutler chuckbutler referenced this pull request Oct 6, 2016

Closed

systemctl does not exist on Trusty #74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment