Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Cleanup when sdn-plugin provider has gone away #92
Conversation
chuckbutler
referenced this pull request
in juju-solutions/charm-flannel
Oct 19, 2016
Closed
juju remove-application cleanup not complete #19
| + except KeyError: | ||
| + hookenv.log('Unable to locate bip or mtu in Docker config.') | ||
| + hookenv.log('Assuming no action required, and restarting the daemon.') | ||
| + |
wwwtyro
Oct 19, 2016
What if bip isn't in opts but mtu is? Seems like we'd fail to remove mtu -- is that acceptable?
chuckbutler
Oct 19, 2016
Collaborator
hmmm, seems odd that you would have an interface MTU configuration without BIP. But i concede the point, that its possible a prior execution could have unintended side effects with checking both inline like this instead of independent checks.
|
For how I understand the DockerOpts object work, we need to pop the key/value off before running. This change looks good to me. +1 |
mbruzek
merged commit f313c6a
into
juju-solutions:master
Oct 19, 2016
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
chuckbutler
referenced this pull request
Oct 24, 2016
Closed
interface sdn-plugin not properly reconfiguring the daemon if the SDN solution is removed #91
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
chuckbutler commentedOct 19, 2016
In the current code in master, the docker daemon is left in a broken
state if the SDN provider ever goes away.
clearer indication of whats happening
reconfigure the daemon
charms.docker 1.11.0 for popping flags out of the dict.