Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Re-add the etcd-proxy relation #13
Conversation
mbruzek
reviewed
May 19, 2016
| @@ -96,6 +96,12 @@ def send_connection_details(client): | ||
| client.provide_connection_string(hosts, config('port')) | ||
| +@when('proxy.connected') | ||
| +def send_cluster_details(proxy): |
|
Not trying to be dense here but i don't understand what the difference is between relations, they both seem to send the connection string around. Also this change could use a readme update rather than letting us guess at which etcd relation to use. |
mbruzek
merged commit e1255a0
into
juju-solutions:master
May 19, 2016
|
One sends the client connection string, and the proxy sends the administrative cluster string. its a single word difference in the code and is a hair confusing, even to myself as the author. When initially porting the code over I omitted this as I thought we could use the db relationship for it all. But thats not the case. It needs the resulting --initial-cluster-string in order to discover all the nodes and set itself up as a proxy. |
chuckbutler commentedMay 17, 2016
This PR re-introduces the etcd-proxy interface and relationship intended for Etcd to distribute its cluster-string (administrative initial-cluster) to remote proxy units, that will bind to localhost and forward traffic to the etcd cluster.
Read more about this feature here: https://coreos.com/etcd/docs/latest/proxy.html