Adds missing implementation of etcd-proxy

[chuckbutler]

The proxy relation now properly sends cluster peer details, and client connection credentials.

[neiljerram]

Thanks - LGTM.

[mbruzek]

Isn't "peer" the same as "thispeer" in this case? Or am I missing a subtlety?

[chuckbutler]

peer becomes the string key of the dict.

'etcd0', so i use it as a scope operator for the dict. We can revise that for better clarity, as i had the same incorrect assumption initially

[mbruzek]

for peer in peers: will create an iterator that makes the peer variable every member of the peers list.
thispeer = peers[peer] is the same thing as peer is it not?

[chuckbutler]

I encourage you to run that, debug it, and tell me what you see. I'm consistently seeing it evaluate to the key, and not the dict of values contained at that key.

[chuckbutler]

@mbruzek was there something we wanted to do with this implementation? @neiljerram has given me a sign off in IRC that it works for their purposes.

[mbruzek]

@chuckbutler I have no problems with this change, the for loop looks a little strange to me, I still think peer and thispeer are equivalent and I don't understand the difference. That looks like unnecessary code to me, but if there is a subtlety that I am missing, a comment would clear that up.

[mbruzek]

OK I am finally +1 to this change.

etcdctl.member_list() actually returns a dictionary (not a list as the method name would imply), so the iterator is on the keys and you need to get the peer member by the key name.