Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Support Xenial, Java 8 by default, and Java 8 on Trusty #2
Conversation
johnsca
added some commits
May 12, 2016
johnsca
changed the title from
Changes to support Java 8 on trusty
to
Support Xenial, Java 8 by default, and Java 8 on Trusty
May 14, 2016
kwmonroe
reviewed
May 15, 2016
| + apt-get update -qq | ||
| + fi | ||
| + | ||
| + if [[ `uname -p` == 'ppc64'* ]]; then |
kwmonroe
May 15, 2016
Member
This looks weird as all get out to me, and I'm not near a prompt on a ppc box to verify. To earn the prestigious +1 you so desire, prove to me that the weird 'ppc64'* string does what you want it to do, that is, match ppc64le.
johnsca
May 16, 2016
•
Edited 1 time
-
johnsca
May 16, 2016
Owner
Edited 1 time
-
May 16, 2016
It's identical to java-installer.sh but if you want further proof:
$ test_cpu_arch="ppc64le"
$ if [[ "$test_cpu_arch" == 'ppc64'* ]]; then
> echo "Power match"
> fi
Power matchEdit: Documented in the note under ==.
|
Thx for the proof. LGTM. |
kwmonroe
merged commit 0e4411a
into
master
May 17, 2016
|
promulgated as cs:openjdk-1 |
kwmonroe
deleted the
java-8-trusty
branch
May 18, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
johnsca commentedMay 12, 2016
No description provided.