This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
Clean up the trusty work-around and other sources handling #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsca
force-pushed
the
cleanup-trusty-workaround
branch
from
a900639
to
5a24e81
Compare
|
Much cleaner! LGTM as soon as the config.default discussion is hashed out. |
| """ | ||
| hookenv.status_set('active', 'puppet is installed') |
There was a problem hiding this comment.
By removing this line this layer will never become active. Meaning that if we charm build this layer and deploy we will be stuck into "maintenance - Installing puppet" state. I guess this is fine when we build on this layer.
There was a problem hiding this comment.
I'm not sure how much value there is in deploying this by itself. If that is something valuable, then we still need to handle setting the status better so as to not conflict with charms building off this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on canonical/layer-basic#57