Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Clean up the trusty work-around and other sources handling #2
Conversation
|
Much cleaner! LGTM as soon as the config.default discussion is hashed out. |
ktsakalozos
reviewed
Apr 20, 2016
| """ | ||
| - hookenv.status_set('active', 'puppet is installed') |
ktsakalozos
Apr 20, 2016
Member
By removing this line this layer will never become active. Meaning that if we charm build this layer and deploy we will be stuck into "maintenance - Installing puppet" state. I guess this is fine when we build on this layer.
johnsca
Apr 21, 2016
Owner
I'm not sure how much value there is in deploying this by itself. If that is something valuable, then we still need to handle setting the status better so as to not conflict with charms building off this.
ktsakalozos
merged commit 4fceb63
into
master
Apr 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
johnsca commentedApr 18, 2016
Depends on juju-solutions/layer-basic#57