Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Adds configuration injection to the openssl conf #26
Conversation
mbruzek
reviewed
Apr 27, 2016
| + conf = f.readlines() | ||
| + for idx,line in enumerate(conf): | ||
| + if '[ CA_default ]' in line: | ||
| + conf.insert(idx + 1, "copy_extensions = copy") |
mbruzek
Apr 27, 2016
•
Edited 1 time
-
mbruzek
Apr 27, 2016
Contributor
Edited 1 time
-
Apr 27, 2016
This isn't idempotent, if this method runs multiple times we could get multiple copy_extension directives. Can you check for the string in conf first and if not do the for loop?
if 'copy_extensions = copy' not in conf:
for idx,line in enumerate(conf):
|
+1 LGTM |
mbruzek
merged commit 447979a
into
juju-solutions:master
Apr 27, 2016
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
chuckbutler
referenced this pull request
May 23, 2016
Closed
final certificate does not contain subject alt names (SAN) #1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
chuckbutler commentedApr 27, 2016
to allow CSR's to carry extensions into their signed certificate.