Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Use absolute paths for the context managers. #47
Conversation
|
@jamesbeedy can you have a look at this PR to see if the changes are legit? |
chuckbutler
reviewed
Aug 26, 2016
| - if os.path.isdir('easy-rsa'): | ||
| - shutil.rmtree('easy-rsa') | ||
| + # Create an absolute path to easy-rsa that is not affected by cwd. | ||
| + easy_rsa_directory = os.path.join(hookenv.charm_dir(), 'easy-rsa') |
|
I like that you've refactored paths to be abs paths. Are we certain that these paths won't be changing in the near term? Minor comment, as we would have had the exact same problem with the relative pathing we were using. +1 LGTM |
|
@mbruzek niceee +1 |
mbruzek
merged commit 0dd76ce
into
juju-solutions:master
Aug 26, 2016
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
mbruzek commentedAug 26, 2016
Fixes #45
I noticed that most of the
chdircontext managers were using relative paths. Make them use absolute paths.