Glitch should only apply changes to apps deployed by the test #24

Closed
johnsca opened this Issue Nov 22, 2016 · 5 comments

Comments

Projects
None yet
2 participants
Owner

johnsca commented Nov 22, 2016

While we should generally run matrix tests on clean models, for dev / testing it's often helpful to (re)run against a pre-deployed model. However, if the current model includes applications that are not part of the matrix test, we might cause mutations to them which are not relevant to the test.

I think glitch should start from context.apps instead of context.juju_model.applications.

Collaborator

petevg commented Nov 23, 2016

I've actually been taking advantage of the fact that matrix will go to town on stuff by deploying things by hand in advance, and then running just the glitch bits of matrix.

That was largely a workaround for when the deploy bits of matrix weren't stable, though. I suppose that need will go away with the actual production version of matrix.

Owner

johnsca commented Nov 23, 2016

I should clarify; as long as the apps are mentioned in the bundle, they will be added to context.apps, even if they were pre-deployed. This should already work, even with the issues with libjuju.

My concern is that the tests will be run with a specific set of charms in mind, and if there are other, unrelated apps in the environment, we should ignore them. Currently, the health check only checks apps in the context.apps list. I suppose another option would be to make all tasks look at the model as a whole, but that seems a bit messier.

Collaborator

petevg commented Nov 23, 2016

@johnsca Aha. Got it. That makes a lot of sense.

Collaborator

petevg commented Dec 13, 2016

@johnsca Is this addressed to your satisfaction by #43?

Owner

johnsca commented Dec 13, 2016

Yep.

@johnsca johnsca closed this Dec 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment