Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Fixed the should_gate test. #109
Conversation
|
@petevg travis seems to be unhappy with your shenanigans. |
|
@kwmonroe Eek. Had another bug. This time I pushed a more complete fix, along with some proper exit codes. Matrix now exits 101 if it ran into a TestFailure, and stuffs the generic exceptions under a generic exit code of 1. Makes things much easier to test! |
petevg
referenced this pull request
Mar 24, 2017
Closed
AttributeError: 'Context' object has no attribute 'ha' #108
johnsca
approved these changes
Mar 24, 2017
LGTM, but given my review track rating, what do I know? ;)
kwmonroe
reviewed
Mar 24, 2017
LGTM, but i learned how to review things from @johnsca, so I haven't actually tested it.
johnsca
merged commit 91ded58
into
master
Mar 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
petevg commentedMar 23, 2017
It was looking in the context, rather than context.config, for the ha
key. This would only fail tests that were failing anyway, but it
clobbered the original Exception, and replaced it with an Exception
raised by my broken check. Whoops.
@kwmonroe @johnsca @abentley @seman