Fixed the should_gate test. #109

Merged
merged 2 commits into from Mar 24, 2017

Conversation

Projects
None yet
3 participants
Collaborator

petevg commented Mar 23, 2017

It was looking in the context, rather than context.config, for the ha
key. This would only fail tests that were failing anyway, but it
clobbered the original Exception, and replaced it with an Exception
raised by my broken check. Whoops.

@kwmonroe @johnsca @abentley @seman

Fixed the should_gate test.
It was looking in the context, rather than context.config, for the ha
key. This would only fail tests that were failing anyway, but it
clobbered the original Exception, and replaced it with an Exception
raised by my broken check. Whoops.
Member

kwmonroe commented Mar 23, 2017

@petevg travis seems to be unhappy with your shenanigans.

Added better test exit codes.
Now exit with 101 in the case of TestFailure, which helps distinguish it
from infra failures.
Collaborator

petevg commented Mar 24, 2017

@kwmonroe Eek. Had another bug. This time I pushed a more complete fix, along with some proper exit codes. Matrix now exits 101 if it ran into a TestFailure, and stuffs the generic exceptions under a generic exit code of 1. Makes things much easier to test!

LGTM, but given my review track rating, what do I know? ;)

LGTM, but i learned how to review things from @johnsca, so I haven't actually tested it.

@johnsca johnsca merged commit 91ded58 into master Mar 24, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment