Feature/jaas support v2 #127

Merged
merged 9 commits into from Apr 27, 2017

Conversation

Projects
None yet
2 participants
Collaborator

petevg commented Apr 26, 2017

Added a -C/--cloud flag so that people can specify a cloud when running against JaaS.

Timeout exceptions now bubble up in a more visible way.

Updated README with notes on JaaS.

@johnsca No longer WIP as we have updated python-libjuju. We still get occasional timeouts connecting to JaaS, but I'm going to split that into a separate ticket.

petevg added some commits Mar 28, 2017

Added ability to specify a cloud in the cli options.
This adds support for JaaS, where the cloud that you might be deploying
to does not necessarily match the controller.
Fixed up JaaS support.
Looser timeouts, and better logging and cleanup when things do go wrong.
+ "could be ambiguous, as in the case of our JaaS "
+ "product, which is a shared controllers that can "
+ "connect to multiple clouds, "
+ "JaaS.")
@petevg

petevg Apr 26, 2017

Collaborator

I want to automagic this param, but I don't think that there's a great way of doing so.

With JaaS, you have to manually specify a cloud. If you don't, and you have creds for multiple clouds, we simply don't have a way of knowing what cloud you meant.

petevg added some commits Apr 26, 2017

Better exception logging for errors adding model.
A Timeout Error has no text, so we lose it. Logging exception will give
us better output for debugging.
Made timeouts even more generous in add_model.
JaaS can take a little while to respond, but the models do get added.
Made timeouts shorter again.
Timeout in add_model probably isn't a timeout, so giving up after a
minute makes a lot of sense.
Removed timeouts from add_model calls.
They weren't working well as diagnostic tools, and we already have other
wrappers around matrix to convince it to timeout.

I think that bare awaits are better -- they surface Exceptions more
easily, and again, we have other layers of code that time things out.

@petevg petevg changed the title from [WIP] Feature/jaas support v2 to Feature/jaas support v2 Apr 27, 2017

@petevg petevg referenced this pull request Apr 27, 2017

Closed

Add compatibility with Jaas #85

@johnsca johnsca merged commit 1e9a74f into master Apr 27, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment