This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
Feature/jaas support v2 #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for JaaS, where the cloud that you might be deploying to does not necessarily match the controller.
Looser timeouts, and better logging and cleanup when things do go wrong.
pengale
commented
Apr 26, 2017
| "could be ambiguous, as in the case of our JaaS " | ||
| "product, which is a shared controllers that can " | ||
| "connect to multiple clouds, " | ||
| "JaaS.") |
There was a problem hiding this comment.
I want to automagic this param, but I don't think that there's a great way of doing so.
With JaaS, you have to manually specify a cloud. If you don't, and you have creds for multiple clouds, we simply don't have a way of knowing what cloud you meant.
A Timeout Error has no text, so we lose it. Logging exception will give us better output for debugging.
JaaS can take a little while to respond, but the models do get added.
Timeout in add_model probably isn't a timeout, so giving up after a minute makes a lot of sense.
They weren't working well as diagnostic tools, and we already have other wrappers around matrix to convince it to timeout. I think that bare awaits are better -- they surface Exceptions more easily, and again, we have other layers of code that time things out.
johnsca
approved these changes
Apr 27, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a -C/--cloud flag so that people can specify a cloud when running against JaaS.
Timeout exceptions now bubble up in a more visible way.
Updated README with notes on JaaS.
@johnsca No longer WIP as we have updated python-libjuju. We still get occasional timeouts connecting to JaaS, but I'm going to split that into a separate ticket.