Remove internal Timeout for matrix tests. #129

Merged
merged 1 commit into from Apr 27, 2017

Conversation

Projects
None yet
2 participants
Collaborator

petevg commented Apr 27, 2017

This is an Alexandrian solution to our "matrix is too green" bug.
(#123)

It also makes things a lot nicer in general. External tools calling
matrix still have to include a timeout, because the existing matrix
timeout only covered hangs during a test run; hangs during setup
or teardown could still lead to a hung matrix. And External tools with
a timeout still have to worry about cleaning up matrix models; having an
internal timeout cleanup that only helps in some cases isn't necessary.

This also simplifies the code, and removes a command line param. A win
all around, I think.

@johnsca @kwmonroe

Remove internal Timeout for matrix tests.
This is an Alexandrian solution to our "matrix is too green" bug.
(#123)

It also makes things a lot nicer in general. External tools calling
matrix still have to include a timeout, because the existing matrix
timeout only covered hangs during a test run; hangs during setup
or teardown could still lead to a hung matrix. And External tools with
a timeout still have to worry about cleaning up matrix models; having an
internal timeout cleanup that only helps in some cases isn't necessary.

This also simplifies the code, and removes a command line param. A win
all around, I think.

+1 assuming travis completes successfully.

@petevg petevg merged commit e344e15 into master Apr 27, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@petevg petevg referenced this pull request Apr 27, 2017

Closed

matrix is too green #123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment