Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Remove internal Timeout for matrix tests. #129
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
petevg commentedApr 27, 2017
This is an Alexandrian solution to our "matrix is too green" bug.
(#123)
It also makes things a lot nicer in general. External tools calling
matrix still have to include a timeout, because the existing matrix
timeout only covered hangs during a test run; hangs during setup
or teardown could still lead to a hung matrix. And External tools with
a timeout still have to worry about cleaning up matrix models; having an
internal timeout cleanup that only helps in some cases isn't necessary.
This also simplifies the code, and removes a command line param. A win
all around, I think.
@johnsca @kwmonroe