/matrix

Feature/hadoop processing fixes #34

Merged
merged 8 commits into from Dec 8, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@petevg @johnsca
@petevg
Collaborator

petevg commented Dec 2, 2016

@bcsaller @johnsca This gets us to the point where we can deploy and run glitch on the hadoop-processing bundle.

Resetting fails -- we run into that "bundle is changing too fast" error. But we already have an issue open related to that.

This probably conflicts w/ #32

Will work on that next ...

petevg added some commits Dec 2, 2016

@petevg
Skip subordinate by default on actions. 
Most of our actions don't really apply to subordinate charms, so we skip
subordinate charms by default when putting a test plan together.

There are some actions, like "upgrade" that do make sense for a
subordinate charm, so I added a method of "tagging" actions with
subordinate okay. The tagging system can also be expanded to handle
other similar circumstances in the future.
062ed18
@petevg
Revert b73edad 
urwid.Terminal was failing on invalid unicode characters. Reverting the
change for now, to unblock hadoop-processing.
2869808
@petevg
remove_unit now no longer remotes last unit in app. 
Removing the last unit in an app is defintely destructive, but isn't
something that we are going to required developers to plan for. Absolute
disaster like that legtimately requires human intervention.
449adfd
@petevg
Got rid of stray import statement.
c0ec79b
@petevg
Added a docstring to tagged_action. 
Hooray for docs!
c83bbf8
@johnsca
Owner

johnsca commented Dec 2, 2016

Out of curiosity, why have two decorators instead of one called as either @action() or @action('tag')?
@petevg
Collaborator

petevg commented Dec 2, 2016 •
Edited 1 time

@johnsca Since most of the actions don't need tags, I figured it was cleaner to have @action for most things. It prevents mistakes, where somebody leaves off the parens because they're not passing any args, and then things break.

@petevg petevg referenced this pull request Dec 6, 2016

Closed

Glitch is too aggressive on non HA bundles #29

@johnsca johnsca merged commit 1ac2fd5 into master Dec 8, 2016

@petevg petevg deleted the feature/hadoop-processing-fixes branch Dec 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment