Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Added try-catch around glitch action functions. #42
Conversation
petevg
referenced this pull request
Dec 8, 2016
Closed
Glitch plan can attempt to operate on removed units #39
|
I think the catch you added was in glitch/actions.py but it turns out we're not getting any kind of exception when this fails. Instead, it's just never returning, even when I added a timeout pass-through arg to libjuju. Glitch plan: http://pastebin.ubuntu.com/23600803/ |
|
Closing, as this does not address the actual problem of timeouts, and we don't really want to be squashing exceptions if we don't have to. |
petevg
closed this
Dec 12, 2016
petevg
deleted the
feature/handle-glitch-exceptions-better
branch
Dec 20, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
petevg commentedDec 8, 2016
Sometimes, glitch will do something broken like try to reboot a unit
that it has just removed.
As a first pass at fixing this, I added a generic catch and log to
glitch actions.
@johnsca @bcsaller