Added try-catch around glitch action functions. #42

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Collaborator

petevg commented Dec 8, 2016

Sometimes, glitch will do something broken like try to reboot a unit
that it has just removed.

As a first pass at fixing this, I added a generic catch and log to
glitch actions.

@johnsca @bcsaller

Added try-catch around glitch action functions.
Sometimes, glitch will do something broken like try to reboot a unit
that it has just removed.

As a first pass at fixing this, I added a generic catch and log to
glitch actions.
Owner

johnsca commented Dec 8, 2016

I think the catch you added was in glitch/actions.py but it turns out we're not getting any kind of exception when this fails. Instead, it's just never returning, even when I added a timeout pass-through arg to libjuju.

Glitch plan: http://pastebin.ubuntu.com/23600803/
Matrix log: http://pastebin.ubuntu.com/23600807/

Collaborator

petevg commented Dec 12, 2016

Closing, as this does not address the actual problem of timeouts, and we don't really want to be squashing exceptions if we don't have to.

@petevg petevg closed this Dec 12, 2016

@petevg petevg deleted the feature/handle-glitch-exceptions-better branch Dec 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment