Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Temporarily update README install instructions #47
Conversation
| - sudo pip3 install 'git+https://github.com/juju-solutions/matrix.git' | ||
| + git clone https://github.com/juju-solutions/matrix.git | ||
| + cd matrix | ||
| + sudo pip3 install . -f wheelhouse |
petevg
Dec 14, 2016
Collaborator
I don't like telling people to install in their system Python. :-/
This command (minus the sudo) fails in a virtualenv, as it can't find zookeeper.h (probably a lib dir missing from the include path).
petevg
Dec 14, 2016
Collaborator
Would prefer:
git clone https://github.com/juju-solutions/matrix.git
cd matrix
tox -r
source .tox/py35/bin/activate
johnsca
Dec 14, 2016
Owner
There are instructions for installing in a venv further down. The point of the default install instructions is to install at the system (or container) level.
A snap for this would be good, but it would have to be unconfined. It's worth looking in to, though, so I created #48
bcsaller
Dec 14, 2016
Contributor
zookeeper.h sounds like its pulling the old python (pre-juju 1.0) bindings that still are in pip and called juju. If you have that sitting around somewhere it would try to build the zookeeper bindings, but nothing modern uses it
sparkiegeek
reviewed
Dec 14, 2016
This still fails (on a freshly minted Xenial LXD with python3-pip and git installed)
|
I was missing the |
| - sudo pip3 install 'git+https://github.com/juju-solutions/matrix.git' | ||
| + git clone https://github.com/juju-solutions/matrix.git | ||
| + cd matrix | ||
| + sudo pip3 install . -f wheelhouse --no-index |
petevg
Dec 14, 2016
Collaborator
Hooray for working things!
Would still prefer evangelizing virtualenvs in all the places, but I can see cutting it out for simplicity :-)
|
+1, as --no-index solved all my problems. |
sparkiegeek
approved these changes
Dec 14, 2016
Works much better. Confirmed I can install matrix on a fresh Xenial LXD following these instructions.
johnsca commentedDec 14, 2016
Until libjuju is released to pypi, our instructions need to include
installing using the wheelhouse. Hopefully this can be reverted very
soon.