Added crashdump action. #56

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
1 participant
Collaborator

petevg commented Dec 21, 2016

Zips up the matrix log, and calls out to the juju-crashdump plugin to
fetch logs and other relevant files from the model.

@johnsca @bcsaller

Added crashdump action.
Zips up the matrix log, and calls out to the juju-crashdump plugin to
fetch logs and other relevant files from the model.

petevg added some commits Dec 22, 2016

Allow empty environment for execute_process
Changed falsey check to "env is None", which allows a caller to pass in
an empty dict, and thus have an empty environment, just in case that is
something that they want to do.
Commented out call to juju-crashdump
Until gh issue#59 (juju ssh not working) is fixed, juju-crashdump will
fail.
Bugfixes for gzipping matrix.log.
We no longer get rid of the original log in the middle of running
matrix, and we no longer break on Exception raising due to a missing
path var.
Fixed up crashdump_test.matrix.
Now actually waits for deploy, and gets relevant logs/crashdump.
Collaborator

petevg commented Dec 22, 2016

@johnsca Ugh. I just realized that there's an issue with this: if a test raises an exception, which is a case where we very much want a crashdump, then we'll never actually run the crashdump task.

Our options are:

a) refactor so that we can run execute_process outside of a task (it's just a wrapper around the asyncio tools, so writing another wrapper wouldn't be too much of a big deal).
b) Come up with a "finally" sort of action, which always executes, even if we've been interrupted by a TestFailure.

Collaborator

petevg commented Dec 23, 2016

Closing. Will resubmit with a crashdump that actually works like we want it to ...

@petevg petevg closed this Dec 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment