Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Added retry loop w/ backoff to model cleanup routine. #71
Conversation
|
Fixing conflicts ... |
petevg
added some commits
Jan 20, 2017
johnsca
merged commit 06253c8
into
master
Feb 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
petevg commentedJan 20, 2017
Also broke the cleanup out into a separate function, for unit testing.
@johnsca @ktsakalozos @kwmonroe Unit testing the RulesEngine class is a bit of a headache. To test this, I just inserted an artificial
raise Exception("test!")in the code, and verified that we tried ten times (the original + 9 retries), and slept the appropriate amount of time between each. I did code it so that it would be easy to add a unit test, once we have a decent harness for testing the RulesEngine.