Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Added support for bundle-provided end-to-end load generator #75
Conversation
| return True | ||
| + | ||
| + | ||
| +async def e2e_output(stream, log_func): |
petevg
Feb 3, 2017
Collaborator
I'd like to see how well this behaves when/if we have a massive number of messages to stdout or stderr. I know that those PIPEs can get filled up, but I'm also assuming that asyncio.gather is going to be able to keep up, and keep pulling data out of them.
It doesn't block a merge, but it is maybe something to keep an eye on as we unleash this thing on real e2e tests.
johnsca
Feb 3, 2017
Owner
Fair enough. I was torn on whether we should even capture the stdout from the e2e script, but it's helpful for debugging, at least.
petevg
merged commit c94fe8b
into
master
Feb 3, 2017
johnsca
referenced this pull request
Feb 23, 2017
Open
Add auto discovery for end to end binaries/tests #55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
johnsca commentedFeb 1, 2017
No description provided.