Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Change rollback-agents to abort #24
Conversation
|
This follows on from #23, the earlier two commits don't need separate reviewing here. |
babbageclunk
requested a review
from
axw
Sep 1, 2017
| + if err != nil { | ||
| + // We still want to rollback the agent upgrades, so just | ||
| + // report this and continue. | ||
| + logger.Errorf("failed to abort model: %s", err.Error()) |
axw
Sep 1, 2017
Member
should probably still cause the command to report non-zero at the end, if rolling back agents succeeds
babbageclunk
added some commits
Sep 1, 2017
babbageclunk
merged commit bafa840
into
juju:master
Sep 1, 2017
babbageclunk
deleted the
babbageclunk:abort
branch
Sep 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
babbageclunk commentedSep 1, 2017
It now will also remove the imported model from the target controller (as
long as it hasn't been activated). If aborting the model fails, the
agents will still be rolled back (and vice versa).