Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add juju storage support for initial charm deploy. #169

Merged
merged 2 commits into from
Jan 10, 2017
Merged

Add juju storage support for initial charm deploy. #169

merged 2 commits into from
Jan 10, 2017

Conversation

tkuhlman
Copy link
Contributor

@tkuhlman tkuhlman commented Jan 9, 2017 •
edited

Juju deployer support's storage as of revno 207.

@tkuhlman tkuhlman mentioned this pull request Jan 9, 2017
Open
@tvansteenburgh
Copy link
Contributor

Looks good, thanks. While we're doing this, can we also add storage support to the Deployment.load() method? I think it's a one-liner addition here: https://github.com/juju/amulet/pull/169/files#diff-dea1f82d61a3ab493d51010f8e3f546dR158

@tvansteenburgh
Copy link
Contributor

LGTM.

@tvansteenburgh tvansteenburgh merged commit c3792fe into juju:master Jan 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tkuhlman @tvansteenburgh