Color Writer: NO_COLOR support #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achilleasa
approved these changes
Sep 24, 2021
jameinel
reviewed
Sep 27, 2021
The following supports the NO_COLOR standard. The idea is that we don't write color to the term if the env var of NO_COLOR is set. The spec states: > Command-line software which adds ANSI color to its output by default should check for the presence of a NO_COLOR environment variable that, when present (regardless of its value), prevents the addition of ANSI color.
SimonRichardson
force-pushed
the
no_color
branch
from
361dba5 to
71a40d6
Compare
jameinel
reviewed
Sep 27, 2021
| file, err := ioutil.TempFile("", "") | ||
| c.Assert(err, gc.IsNil) | ||
|
|
||
| os.Setenv("NO_COLOR", "") |
There was a problem hiding this comment.
should we be deferring something to restore NO_COLOR to its original value? Otherwise parts of the test suite will be running in a different context than the rest.
|
!!build!! |
4 similar comments
|
!!build!! |
|
!!build!! |
|
!!build!! |
|
!!build!! |
|
Build finished. |
|
|
|
Build finished. |
|
!!build!! |
|
Build finished. |
|
|
|
Build finished. |
1 similar comment
|
Build finished. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following supports the NO_COLOR standard. The idea is that we don't
write color to the term if the env var of NO_COLOR is set to anything
that can be truthy.
This brings juju inline with more new CLI.
See: https://no-color.org/