/bundlechanges

Add Series attribute to AddCharmParams #17

Merged
merged 3 commits into from Mar 10, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@wallyworld @jujugui @axw
@wallyworld
Owner

wallyworld commented Mar 10, 2016

When a charm is added, we support the bundle specifying the series.
@jujugui
Member

jujugui commented Mar 10, 2016

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
http://ci.jujugui.org:8080//job/bundlechanges/46/
Test FAILed.
@axw
Member

axw commented Mar 10, 2016

LGTM, looks like you need to update the charm package first though.
@jujugui
Member

jujugui commented Mar 10, 2016

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
http://ci.jujugui.org:8080//job/bundlechanges/47/
Test FAILed.
@jujugui
Member

jujugui commented Mar 10, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://ci.jujugui.org:8080//job/bundlechanges/48/
Test PASSed.
@wallyworld
Owner

wallyworld commented Mar 10, 2016

:shipit:
@jujugui
Member

jujugui commented Mar 10, 2016

Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/bundlechanges-merge

jujugui added a commit that referenced this pull request Mar 10, 2016

@jujugui
Merge pull request #17 from wallyworld/add-charm-series-attribute 
Add Series attribute to AddCharmParams

When a charm is added, we support the bundle specifying the series.
2618de2

@jujugui jujugui merged commit 2618de2 into juju:master Mar 10, 2016
1 check passed

1 check passed

default Merged build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment