/bundlechanges

Add support for resources. #19

Merged
merged 7 commits into from Mar 16, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@ericsnowcurrently @jujugui @frankban @natefinch @kat-co
@ericsnowcurrently
Contributor

ericsnowcurrently commented Mar 15, 2016

No description provided.

@jujugui
Member

jujugui commented Mar 15, 2016

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
http://ci.jujugui.org:8080//job/bundlechanges/52/
Test FAILed.
changes.go
+ if resources == nil {
+ resources = make(map[string]int, 0)
+ }
+ return []interface{}{ch.Params.Charm, ch.Params.Service, options, ch.Params.Constraints, storage, endpointBindings, resources}
@frankban

frankban Mar 16, 2016

Member

The GUI should be ready to accept the new resources argument before adding them here.
I'd say let's leave GUIArgs untouched for now.

@frankban

frankban Mar 16, 2016

Member

Maybe add a TODO comment?

@ericsnowcurrently

ericsnowcurrently Mar 16, 2016

Contributor

Sounds good. I'm glad you noticed this. It was the one thing I was unsure about. :)

@frankban
Member

frankban commented Mar 16, 2016

👍 with a change.
Thank you!
@jujugui
Member

jujugui commented Mar 16, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://ci.jujugui.org:8080//job/bundlechanges/53/
Test PASSed.
@jujugui
Member

jujugui commented Mar 16, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://ci.jujugui.org:8080//job/bundlechanges/54/
Test PASSed.
@natefinch

natefinch commented Mar 16, 2016

👍
@kat-co

kat-co commented Mar 16, 2016

+1
@ericsnowcurrently
Contributor

ericsnowcurrently commented Mar 16, 2016

:shipit:
@jujugui
Member

jujugui commented Mar 16, 2016

Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/bundlechanges-merge

jujugui added a commit that referenced this pull request Mar 16, 2016

@jujugui
Merge pull request #19 from ericsnowcurrently/resources-add-to-service 
Add support for resources.
383c581

@jujugui jujugui merged commit 383c581 into juju:master Mar 16, 2016
1 check passed

1 check passed

default Merged build finished.
Details

@ericsnowcurrently ericsnowcurrently deleted the ericsnowcurrently:resources-add-to-service branch Mar 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment