Add enable-fwaas to neutron api context #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces enable-fwaas to neutron api context Updates l3_extension_plugins based on new context variable enable-fwaas Backport of PR#635 to stable/21.04 fixes: #lp1934129 (cherry picked from commit 4fa1777)
|
Spoken to @hemanthnakkina and he is going to queue up the associated charm backports for neutron-gateway and neutron-openvswitch charms to ensure they land asap after this does to ensure there is no unexpected behaviour should someone sync this into those charms before the backports land. |
lourot
approved these changes
Sep 17, 2021
There was a problem hiding this comment.
LGTM, thanks! For reference here are the charm backports that will make use of this: https://review.opendev.org/q/topic:%22bug%252F1934129%22
openstack-mirroring
pushed a commit
to openstack/charm-neutron-api
that referenced
this pull request
Sep 17, 2021
Add enable-fwaas to neutron-plugin-api relation data so that neutron-openvswitch updates neutron-l3-agent configuration accordingly. Synced charmhelpers to get related changes juju/charm-helpers#640 Partial-Bug: #1934129 (cherry picked from commit 69af89a) Change-Id: I5019c5ed3b8ab556d4900f1fe46dee69f5f09ee7
openstack-mirroring
pushed a commit
to openstack/charm-neutron-openvswitch
that referenced
this pull request
Sep 20, 2021
fwaas_v2 extension is added in l3_agent.ini by default from stein. However with the newly introduced neutron-api configuration parameter enable-fwaas, the extension have to added only when it is set to true on neutron-api charm. neutron-api charm adds enabled-fwaas as relation data in the commit https://review.opendev.org/c/openstack/charm-neutron-api/+/806676. This patch removes special handling of fwaas_v2 as l3_extension_plugins is already updated in relation data based on neutron-api enable-fwaas configuration. Add python3-neutron-fwaas in py3 package list only for rocky release. The package is already part of dependency of neutron-l3-agent until Ussuri release and the dependency will be removed from Victoria release in package control files. Synced charmhelpers to get related changes juju/charm-helpers#640 Closes-Bug: #1934129 Change-Id: I1546f45635bfd7af76001c1df4f99d219a9d8039 (cherry picked from commit d3daa09)
openstack-mirroring
pushed a commit
to openstack/charm-neutron-gateway
that referenced
this pull request
Sep 20, 2021
fwaas_v2 extension is added in l3_agent.ini by default from stein. However with the newly introduced neutron-api configuration parameter enable-fwaas, the extension have to added only when it is set to true on neutron-api charm. neutron-api charm adds enabled-fwaas as relation data in the commit https://review.opendev.org/c/openstack/charm-neutron-api/+/806676. This patch removes special handling of fwaas_v2 as l3_extension_plugins is already updated in relation data based on neutron-api enable-fwaas configuration. Remove python3-neutron-fwaas in package list from stein release. The package is already part of dependency of neutron-l3-agent until Ussuri release and the dependency will be removed from Victoria release in package control files. Synced charmhelpers to get related changes juju/charm-helpers#640 Partial-Bug: #1934129 Change-Id: I07db7fb7c2f00eaf4c0a5bcc082c73922b87d1c0 (cherry picked from commit de22d6c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR#635 to stable/21.04
fixes: #lp1934129
(cherry picked from commit 4fa1777)