series in metadata deprecates need to put charms in /series/ directory #115

Closed
marcoceppi opened this Issue Feb 12, 2016 · 5 comments

Comments

Projects
None yet
4 participants
Owner

marcoceppi commented Feb 12, 2016

We should just build them into $JUJU_REPOSITORY/<charm> now, or somewhere more generic

@marcoceppi marcoceppi added this to the 2.0 milestone Feb 12, 2016

@marcoceppi marcoceppi self-assigned this Feb 12, 2016

@marcoceppi marcoceppi removed their assignment Mar 12, 2016

Member

tvansteenburgh commented Mar 13, 2016

Perhaps we do this if the charm does indeed declare its series in metadata, but if not, continue to build into a series dir?

Owner

marcoceppi commented Mar 13, 2016

Sounds smart, as long as we continue to tell the use what's going on.
There's also a potential for collision if the charm is called $LAYER_PATH
or INTERFACE_PATH basename. However, I doubt that will be an issue.

On Sun, Mar 13, 2016, 5:22 PM Tim Van Steenburgh notifications@github.com
wrote:

Perhaps we do this if the charm does indeed declare its series in
metadata, but if not, continue to build into a series dir?


Reply to this email directly or view it on GitHub
#115 (comment).

Owner

mitechie commented Mar 14, 2016

What about using this to help users pick a default series? How disruptive would it be to toss a warning/error at the user here?

Contributor

stub42 commented Mar 14, 2016

Charms may require no default series to support Juju 1.x, so I'd balk at a warning or error.

@marcoceppi marcoceppi modified the milestones: 2.NEXT, 2.0 Mar 22, 2016

Owner

marcoceppi commented Mar 25, 2016

Whenever there is a series key in output, the directory should just be builds, otherwise the current series path should continue.

@marcoceppi marcoceppi modified the milestones: 2.1, 2.NEXT Mar 25, 2016

tvansteenburgh added a commit to tvansteenburgh/charm-tools that referenced this issue Mar 29, 2016

Don't build multi-series charms into a series dir
- If no series given on cmd line and charm is multi-series
  ('series' key in metadata.yaml), don't build in a series dir
- If no series given on cmd line and charm is not multi-series,
  build in default series dir.
- 'charm_name' property removed b/c it's not used anywhere.

Fixes #115.

@marcoceppi marcoceppi closed this in #162 Mar 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment