/charm-tools

fetcher should support generic git #124

Closed
ChrisMacNaughton opened this Issue Mar 4, 2016 · 4 comments

Comments

Assignees

@tvansteenburgh tvansteenburgh

Labels
None yet
Projects
None yet
Milestone
  2.0
4 participants
@ChrisMacNaughton @verterok @marcoceppi @tvansteenburgh
@ChrisMacNaughton

ChrisMacNaughton commented Mar 4, 2016

Limiting layers / interfaces to being hosted on Github and Launchpad is frustrating, I'd love to have support for generic git endpoints.
@verterok

verterok commented Mar 9, 2016

Looks like this is the culprit: https://github.com/juju/charm-tools/blob/master/charmtools/build/fetchers.py#L73
@marcoceppi
Owner

marcoceppi commented Mar 12, 2016

This was fixed by #128

@marcoceppi marcoceppi closed this Mar 12, 2016

@marcoceppi marcoceppi added this to the 2.0 milestone Mar 12, 2016

@tvansteenburgh
Member

tvansteenburgh commented Mar 12, 2016

Actually this is not really fixed. The only git fetchers we have at the moment are specific to Github and Launchpad. See https://github.com/juju/charm-tools/blob/master/charmtools/fetchers.py#L163, and also line 178.

It's simple to add new fetchers though. Since fetchers are based on regex matching, a generic git fetcher might just try to match on 'git'.

@tvansteenburgh tvansteenburgh reopened this Mar 12, 2016

@ChrisMacNaughton

ChrisMacNaughton commented Mar 14, 2016

or even git://.*.git to be more specific and match less things

@tvansteenburgh tvansteenburgh self-assigned this Mar 14, 2016

@marcoceppi marcoceppi closed this in faf0cd1 Mar 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment