lower layers that define series will be included in built charm #257

Open
battlemidget opened this Issue Sep 20, 2016 · 1 comment

Comments

Projects
None yet
2 participants
Collaborator

battlemidget commented Sep 20, 2016

Otherwise, if you have a feature request or issue with any other charm command please delete the above and continue below

Checklist

  • Confirmed this is an issue with charm-tools, not charmstore-client
  • [X ] Provide versions of tools used
  • Described the feature or ways to replicate the issue

What version am I running?

I ran the following command: charm version and got the following ouput:

charm 2.1.1-0ubuntu1
charm-tools 2.1.2

I am using: ubuntu

Issue/Feature

Doing a charm build that includes layers such as nginx which define a series in its metadata.yaml will be included in the top level charm being built. This results in the finished charm including either multiple series name (ie: series: ['xenial', 'trusty', 'xenial']) or set the final charm up to support additional series that may not have been developed for.

I expect/expected the following

If this toplevel contains a series definition it should use that as the authoritative source of what series it supports.

Happens here as well. This issue might be related: #186

battlemidget added a commit to battlemidget/layer-php that referenced this issue Sep 26, 2016

Update metadata.yaml
When building this layer we'll hit juju/charm-tools#257, this should take care of that

@battlemidget battlemidget referenced this issue in silph-io/layer-php Sep 26, 2016

Merged

Update metadata.yaml #2

marcoceppi added a commit to silph-io/layer-php that referenced this issue Sep 26, 2016

#2: Update metadata.yaml, removing series
When building this layer we'll hit juju/charm-tools#257, this should take care of that

cmars added a commit to cmars/juju-charm-mattermost that referenced this issue Oct 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment