Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Addresses issue 99 where Juju has a problem with strings starting with zero #104
Conversation
mbruzek
added some commits
Feb 6, 2016
|
Lgtm, the hash is the has of the file. So this needs to be updated since content has changed. Did not QA, will wait for travis |
|
Fixes #99 |
|
@marcoceppi the hash was for |
marcoceppi
added this to the
PATCH milestone
Feb 6, 2016
added a commit
that referenced
this pull request
Feb 6, 2016
marcoceppi
merged commit 45bfaeb
into
juju:master
Feb 6, 2016
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
|
@mbruzek can you open a bug against the go-yaml library Juju uses to fix this at its source? |
marcoceppi
referenced this pull request
Feb 7, 2016
Merged
Adjusted the deep merge operation to support merging of lists #103
|
@srbaker This charm-tools patch works around your problem, but I have traced the root back to the go-yaml implementation and opened an issue go-yaml/yaml#157 |
mbruzek
referenced this pull request
Feb 9, 2016
Closed
charm build on yaml needs to do proper type casting #99
marcoceppi
modified the milestones:
2.0,
PATCH
Mar 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
mbruzek commentedFeb 6, 2016
This pull forces all strings to use quotes so Juju does not try to read the yaml string 01182252 as an int.
Adding configuration and tests so this does not revert in the future.
I also had to fix a hash on metadata.yaml in the tests, don't know what that was about other than the test was failing when I found it.