Fixed #102: Report useful error message when fetch fails due to missing VCS tool #108

Merged
merged 1 commit into from Feb 12, 2016

Conversation

Projects
None yet
2 participants
Member

johnsca commented Feb 12, 2016

build: Composing into /home/ubuntu/t
build: Unable to run "git": No such file or directory
charmtools/fetchers.py
+ **kw
+ )
+ except OSError as e:
+ raise FetchError('Unable to run "%s": %s' % (args[0], e.strerror))
@marcoceppi

marcoceppi Feb 12, 2016

Owner
msg = 'Unable to run "%s": %s' % (args[0], e.strerror)
if e.errno == 127:
    msg = msg + '\nPlease install "%s" before continuing.' % args[0]
raise FetchError(msg)

That way the user has an actionable item?

Owner

marcoceppi commented Feb 12, 2016

⛵️ LGTM

marcoceppi added a commit that referenced this pull request Feb 12, 2016

Merge pull request #108 from johnsca/issue-102
Fixed #102: Report useful error message when fetch fails due to missing VCS tool

@marcoceppi marcoceppi merged commit 8de7743 into juju:road-to-2.0 Feb 12, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@marcoceppi marcoceppi added this to the 2.0 milestone Feb 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment