/charm-tools

Fixed #77: Added templates for reactive charms #113

Merged
merged 1 commit into from Feb 13, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  2.0
2 participants
@johnsca @marcoceppi
@johnsca
Member

johnsca commented Feb 12, 2016

Set reactive-python to the default

@marcoceppi marcoceppi added this to the 2.0 milestone Feb 12, 2016

@marcoceppi
Owner

marcoceppi commented Feb 12, 2016

Would it be better to host these in github.com/juju-solutions/reactive-{python,bash} and just have the create command clone them? That way as we iterate on the templates we don't have to push a release out?

Reference: #100
@johnsca
Member

johnsca commented Feb 12, 2016

Agreed. I was trying to bang these out pretty quickly, but I will refactor it to follow that pattern.
@marcoceppi
Owner

marcoceppi commented Feb 13, 2016

LGTM ⛵️

marcoceppi added a commit that referenced this pull request Feb 13, 2016

@marcoceppi
Merge pull request #113 from johnsca/issue-77 
Fixed #77: Added templates for reactive charms
474b26c

@marcoceppi marcoceppi merged commit 474b26c into juju:road-to-2.0 Feb 13, 2016
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@marcoceppi marcoceppi referenced this pull request Feb 28, 2016

Closed

`charm create` should output a reactive charm #77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment