Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Add --show-report option to charm-build #135
Conversation
|
YES! |
|
Making some refactors to use existing delta_signatures logic as suggested in IRC. |
marcoceppi
reviewed
Mar 15, 2016
| @@ -588,6 +623,8 @@ def main(args=None): | ||
| default="http://interfaces.juju.solutions") | ||
| parser.add_argument('-n', '--name', | ||
| help="Build a charm of 'name' from 'charm'") | ||
| + parser.add_argument('-r', '--show-report', action="store_true", |
marcoceppi
reviewed
Mar 15, 2016
| + old_sigs = self.old_manifest['signatures'] | ||
| + if not old_sigs: | ||
| + log.info('') | ||
| + log.info('---------------------------------------') |
|
Made some changes based on review. @marcoceppi The report format is basically machine-readable but is still mixed in with the log output. I suppose we might want to dump it to a file at some point with less header info, but at that point it could maybe just be added to the |
|
LGTM :BOAT: |
|
LGTM, thanks |
added a commit
that referenced
this pull request
Mar 15, 2016
marcoceppi
merged commit 9860721
into
juju:master
Mar 15, 2016
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
johnsca commentedMar 15, 2016
This option enables a post-build report detailing what files have changed, based on the signatures in the existing
.build.manifest