/charm-tools

Validate layers for options (fixes #173) #175

Merged
merged 1 commit into from Apr 4, 2016
+18 −6

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
charm-build
Projects
None yet
Milestone
  2.1.3
2 participants
@johnsca @marcoceppi
@johnsca
Member

johnsca commented Apr 4, 2016 •
Edited 1 time

Ensure that options are only set for layers that are included.
This also ensures that one doesn't forget to nest the options under the
layer name.

Note: The additionalProperties is actually sufficient, but produces a
somewhat obscure error message.

fixes #173
@johnsca
Validate layers for options (fixes #173) 
Ensure that options are only set for layers that are included.
This also ensures that one doesn't forget to nest the options under the
layer name.

Note: The `additionalProperties` is actually sufficient, but produces a
somewhat obscure error message.
134e860
@marcoceppi
Owner

marcoceppi commented Apr 4, 2016

LGTM ⛵️

@marcoceppi marcoceppi merged commit 4f4b609 into juju:master Apr 4, 2016
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@marcoceppi marcoceppi added this to the 2.1.PATCH milestone Apr 4, 2016

@marcoceppi marcoceppi added the charm-build label Apr 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment