/charm-tools

Fix tactic loader #191

Merged
merged 3 commits into from Apr 28, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
charm-build
Projects
None yet
Milestone
  2.1.3
3 participants
@bcsaller @johnsca @marcoceppi
@bcsaller
Contributor

bcsaller commented Apr 22, 2016 •
Edited 1 time

Description of change

Checklist

  • Have you followed Juju Solutions hacking guide?
  • Are all your commits [logically] grouped and squashed appropriately?
  • Does this patch have code coverage?
  • Does your code pass make test?
@johnsca
Member

johnsca commented on charmtools/utils.py in e06e421 Apr 19, 2016

May I recommend:

module_path, class_name = full_class_string.rsplit('.', 1)

bcsaller added some commits Apr 22, 2016

@bcsaller
cleaner splits in classpath handling

All checks have passed

2 successful checks
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
64adc79
@bcsaller
Merge branch 'master' into fix_tactic_loader

All checks have passed

2 successful checks
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
164798c

@marcoceppi marcoceppi added this to the 2.1.PATCH milestone Apr 28, 2016

@marcoceppi marcoceppi merged commit f0fb2c9 into master Apr 28, 2016
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@marcoceppi marcoceppi deleted the fix_tactic_loader branch Apr 28, 2016

marcoceppi added a commit that referenced this pull request Apr 28, 2016

@bcsaller @marcoceppi
#191: Fix tactic loader (fixes #184) 
* testing fix for import loader of tactics
* cleaner splits in classpath handling
80c336f

@marcoceppi marcoceppi added the charm-build label Apr 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment