Pinning the ruamel.yaml version in setup.py same as requirements.txt #232

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

mbruzek commented Jul 12, 2016

Description of change

Checklist

  • Have you followed Juju Solutions hacking guide?
  • Are all your commits [logically] grouped and squashed appropriately?
  • Does this patch have code coverage?
  • Does your code pass make test?

I had a newer version of ruamel.yaml installed, when I issued pip install -e . I got the pinned version of ruamel.yaml-0.10.23

$ sudo pip install -e .
...
Installing collected packages: ruamel.yaml, charm-tools
  Found existing installation: ruamel.yaml 0.11.6
    Uninstalling ruamel.yaml-0.11.6:
      Successfully uninstalled ruamel.yaml-0.11.6
  Running setup.py develop for charm-tools
Successfully installed charm-tools-2.1.2 ruamel.yaml-0.10.23
Contributor

mbruzek commented Jul 12, 2016

References from our IRC conversation:
(08:55:05 AM) cory_fu: mbruzek: Hrm. It's pinned in requirements.txt: https://github.com/juju/charm-tools/blob/master/requirements.txt#L20 but not in setup.py: https://github.com/juju/charm-tools/blob/master/setup.py#L16

Member

johnsca commented Jul 12, 2016

Please see #233. We need to update the pinned version as well, unfortunately.

Contributor

mbruzek commented Jul 12, 2016

OK updated to version 0.11.14

$ sudo pip install -e .
...
Installing collected packages: ruamel.yaml, charm-tools
  Found existing installation: ruamel.yaml 0.10.23
    Uninstalling ruamel.yaml-0.10.23:
      Successfully uninstalled ruamel.yaml-0.10.23
  Running setup.py develop for charm-tools
Successfully installed charm-tools-2.1.2 ruamel.yaml-0.11.14

And charmtools still passes make test

Owner

marcoceppi commented Jul 12, 2016

nope, we need to mirror what's in Xenial guys.

http://packages.ubuntu.com/xenial/python-ruamel.yaml - 0.10.23

@mbruzek mbruzek closed this Nov 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment