proof the actual built charm #256

Merged
merged 1 commit into from Sep 10, 2016

Conversation

Projects
None yet
3 participants
Owner

marcoceppi commented Sep 10, 2016

This changes the output from this:

build: Composing into /home/marco/Projects/silph.co
build: Destination charm directory: /home/marco/Projects/silph.co/trusty/silph-web
build: Please add a `repo` key to your layer.yaml, e.g. repo: git@bitbucket.org:marcoceppi/layer-thesilphroad.git
build: Processing layer: layer:basic
build: Processing layer: layer:nginx
build: Processing layer: layer:apt
build: Processing layer: layer:php-fpm
build: Processing layer: silph-web
build: Processing interface: http
build: Processing interface: php-fpm-stats
build: Processing interface: mysql
build: Processing interface: redis
proof: I: no hooks directory
proof: W: no copyright file
proof: W: README.md includes boilerplate: Step by step instructions on using the charm:
proof: W: README.md includes boilerplate: You can then browse to http://ip-address to configure the service.
proof: W: README.md includes boilerplate: - Upstream mailing list or contact information
proof: W: README.md includes boilerplate: - Feel free to add things if it's useful for users
proof: I: relation website has no hooks
proof: I: relation cache has no hooks
proof: I: relation database has no hooks
proof: I: missing recommended hook install
proof: I: missing recommended hook start
proof: I: missing recommended hook stop
proof: I: missing recommended hook config-changed
proof: I: config.yaml: option ssh-key has no default value

Which, as you can see, i sproofing the current (layer) directory. Into:

build: Composing into /home/marco/Projects/silph.co
build: Destination charm directory: /home/marco/Projects/silph.co/trusty/silph-web
build: Please add a `repo` key to your layer.yaml, e.g. repo: git@bitbucket.org:marcoceppi/layer-thesilphroad.git
build: Processing layer: layer:basic
build: Processing layer: layer:nginx
build: Processing layer: layer:apt
build: Processing layer: layer:php-fpm
build: Processing layer: silph-web
build: Processing interface: http
build: Processing interface: php-fpm-stats
build: Processing interface: mysql
build: Processing interface: redis
proof: W: README.md includes boilerplate: Step by step instructions on using the charm:
proof: W: README.md includes boilerplate: You can then browse to http://ip-address to configure the service.
proof: W: README.md includes boilerplate: - Upstream mailing list or contact information
proof: W: README.md includes boilerplate: - Feel free to add things if it's useful for users
proof: I: config.yaml: option ssh-key has no default value

Which is now proofing the actual layer

@marcoceppi marcoceppi added this to the 2.1.PATCH milestone Sep 10, 2016

Member

johnsca commented Sep 10, 2016

👍

@marcoceppi marcoceppi merged commit 3ae0a02 into juju:master Sep 10, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
+ if not lint:
+ llog.info('OK!')
+
+ for line in lint:
@kwmonroe

kwmonroe Sep 10, 2016

Member

what if (one day) lint is none? you would be laughed at. please add an else.

@marcoceppi marcoceppi referenced this pull request Sep 19, 2016

Closed

Use build output dir for proof (fixes #222) #236

4 of 4 tasks complete

marcoceppi added a commit that referenced this pull request Oct 1, 2016

@marcoceppi marcoceppi referenced this pull request Oct 27, 2016

Closed

Linting a layer rather than the built artifact #270

3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment