Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicates from series field in metadata tactic fixes #297 #298

Merged
merged 1 commit into from Jan 26, 2017
Merged

Remove duplicates from series field in metadata tactic fixes #297 #298

merged 1 commit into from Jan 26, 2017

Conversation

marcoceppi
Copy link
Contributor

@marcoceppi marcoceppi commented Jan 5, 2017 •
edited

This de-duplicates metadata series and fixes #297

@johnsca
Copy link
Contributor

johnsca commented Jan 5, 2017

Do you think you could add a trusty series to the mysql layer's metadata.yaml to ensure that de-dupe works across layers as well (since you ran in to that while testing)?

johnsca
johnsca approved these changes Jan 6, 2017
View reviewed changes
Copy link
Contributor

@johnsca johnsca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@marcoceppi marcoceppi merged commit 2c93853 into juju:master Jan 26, 2017
marcoceppi added a commit that referenced this pull request Jan 26, 2017
@marcoceppi
#298: Remove duplicates from series field in metadata tactic (fixes #297
f1e589a 
)

# Conflicts:
#	charmtools/build/tactics.py
#	tests/test_build.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnsca johnsca johnsca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Charm build creates duplicated series entries
2 participants
@marcoceppi @johnsca