/charm-tools

Remove duplicates from series field in metadata tactic fixes #297 #298

Merged
merged 1 commit into from Jan 26, 2017

Conversation

Reviewers

@johnsca johnsca

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@marcoceppi @johnsca
@marcoceppi
Owner

marcoceppi commented Jan 5, 2017 •
Edited 1 time

This de-duplicates metadata series and fixes #297
@johnsca
Member

johnsca commented Jan 5, 2017

Do you think you could add a trusty series to the mysql layer's metadata.yaml to ensure that de-dupe works across layers as well (since you ran in to that while testing)?
@johnsca

johnsca approved these changes Jan 6, 2017
View changes

LGTM 👍

@marcoceppi marcoceppi merged commit 2c93853 into juju:master Jan 26, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

marcoceppi added a commit that referenced this pull request Jan 26, 2017

@marcoceppi
#298: Remove duplicates from series field in metadata tactic (fixes #297 
)

# Conflicts:
#	charmtools/build/tactics.py
#	tests/test_build.py
f1e589a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment