/charm-tools

Use Python 3 for layered charms #55

Merged
merged 2 commits into from Dec 4, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  1.10.0
2 participants
@johnsca @marcoceppi
@johnsca
Member

johnsca commented Dec 1, 2015

This depends on juju-solutions/reactive-base-layer#10.

@johnsca johnsca referenced this pull request in juju-solutions/layer-basic Dec 1, 2015

Merged

Use Python 3 for layers #10

@marcoceppi
Owner

marcoceppi commented Dec 1, 2015

Does this mean python3-pip and python3-dev are required deps for charm-tools?
@johnsca
Member

johnsca commented Dec 1, 2015

It would depend on python3 and python3-pip until we remove the InstallerTactic. The WheelhouseTactic uses virtualenv, so I'm not sure if that requires python3-pip or not.

I can't see why it would depend on python3-dev

Edit: Correction, python-virtualenv and python3 are required, but not python3-pip nor python3-dev.

@johnsca johnsca referenced this pull request Dec 1, 2015

Closed

base layer hooks hardcode Python2 #37

@marcoceppi marcoceppi modified the milestones: 1.9.4, NEXT, 1.10.0 Dec 3, 2015

marcoceppi added a commit that referenced this pull request Dec 4, 2015

@marcoceppi
Merge pull request #55 from johnsca/python3 
Use Python 3 for layered charms
395a2d6

@marcoceppi marcoceppi merged commit 395a2d6 into juju:master Dec 4, 2015
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment