Resolve #66: Add reactive hooks for storage #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if target.exists(): | ||
| continue | ||
| target.parent.makedirs_p() | ||
| target.write_text(self.STORAGE_BINDING.format(name)) |
There was a problem hiding this comment.
Storage does not follow {storage-name}-relation-{hook} but rather {storage-name}-attached and {storage-name}-detaching} ref. I don't see how that would be created form this.
|
This code could benefit from class and method comments in this code as I don't fully understand the what "tactics" are. I saw that you created some test data files but no tests for the new storage stuff. Are those to come later? |
|
⛵ |
marcoceppi
added a commit
that referenced
this pull request
Dec 4, 2015
Resolve #66: Add reactive hooks for storage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.