Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Resolve #66: Add reactive hooks for storage #67
Conversation
johnsca
referenced this pull request
in juju-solutions/layer-basic
Dec 4, 2015
Closed
Missing base hooks: leadership, update-status, storage #4
marcoceppi
reviewed
Dec 4, 2015
| + if target.exists(): | ||
| + continue | ||
| + target.parent.makedirs_p() | ||
| + target.write_text(self.STORAGE_BINDING.format(name)) |
marcoceppi
Dec 4, 2015
Owner
Storage does not follow {storage-name}-relation-{hook} but rather {storage-name}-attached and {storage-name}-detaching} ref. I don't see how that would be created form this.
|
This code could benefit from class and method comments in this code as I don't fully understand the what "tactics" are. I saw that you created some test data files but no tests for the new storage stuff. Are those to come later? |
marcoceppi
added this to the
1.9.4 milestone
Dec 4, 2015
|
|
added a commit
that referenced
this pull request
Dec 4, 2015
marcoceppi
merged commit 18c17b6
into
juju:master
Dec 4, 2015
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
johnsca commentedDec 4, 2015
No description provided.