Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Add leader and status new hooks #122
Conversation
wallyworld
reviewed
Apr 27, 2015
hooks/hooks.go
| + ActionRequested Kind = "action-requested" // TODO: remove in charm v5, DEPRECATED | ||
| + Action Kind = "action" | ||
| + CollectMetrics Kind = "collect-metrics" | ||
| + UpdateStatus Kind = "update-status" |
wallyworld
Apr 27, 2015
Owner
could this please be moved to the end of the list, as where it is now splits up the CollectMetrics and MeterStatusChanged hooks which belong together. Same comment applies to other files.
|
LGTM |
|
$$merge$$ |
perrito666
added some commits
Apr 27, 2015
added a commit
that referenced
this pull request
May 11, 2015
perrito666
merged commit ae1713e
into
juju:v5
May 11, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
perrito666 commentedApr 27, 2015
These hooks are required for:
Leader election, these are alredy defined but in the wrong place
inside juju core.
Health status, we add an update-status hook.