hooks: s/storage-detached/storage-detaching/ #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axw
force-pushed
the
charm-hooks-storage-detaching
branch
from
0eef354
to
82dda08
Compare
|
LGTM |
axw
added a commit
that referenced
this pull request
Apr 30, 2015
hooks: s/storage-detached/storage-detaching/
|
For the record, this is an API-breaking change and as such should not have landed |
rogpeppe
pushed a commit
to rogpeppe-contrib/charm
that referenced
this pull request
May 5, 2015
hooks: s/storage-detached/storage-detaching/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename storage-detached to storage-detaching. The hook will be run before storage is detached, to give charms an opportunity to cleanly release.