/charm

hooks: s/storage-detached/storage-detaching/ #125

Merged
merged 1 commit into from Apr 30, 2015
+4 −4

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@axw @wallyworld @rogpeppe
@axw
Member

axw commented Apr 29, 2015

Rename storage-detached to storage-detaching. The hook will be run before storage is detached, to give charms an opportunity to cleanly release.
@wallyworld
Owner

wallyworld commented Apr 30, 2015

LGTM

axw added a commit that referenced this pull request Apr 30, 2015

@axw
Merge pull request #125 from axw/charm-hooks-storage-detaching 
hooks: s/storage-detached/storage-detaching/
7793941

@axw axw merged commit 7793941 into juju:v5 Apr 30, 2015

@rogpeppe
Owner

rogpeppe commented May 5, 2015

For the record, this is an API-breaking change and as such should not have landed
in charm.v5.

rogpeppe added a commit to rogpeppe/charm that referenced this pull request May 5, 2015

@axw @rogpeppe
Merge pull request #125 from axw/charm-hooks-storage-detaching 
hooks: s/storage-detached/storage-detaching/
40accac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment